L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-49399 task: Remove hardcoded LIMIT

Browse Source
This commit is contained in:
Andrew Nicols
2019-01-17 08:02:24 +08:00
parent cca12f68d0
commit 987d112340
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/classes/task/database_logger.php
+10 -9
View File
@@ -128,21 +128,22 @@ class database_logger implements task_logger {
$classes = $DB->get_fieldset_sql($sql, $params);
foreach ($classes as $classname) {
$notinsql = "";
$params = [
'classname' => $classname,
];
$retaincount = (int) $CFG->task_logretainruns;
$keeplogs = $DB->get_fieldset_sql(
"SELECT id FROM {task_log} WHERE classname = :classname ORDER BY timestart DESC LIMIT {$retaincount}",
$params
);
if ($retaincount) {
$keeplogs = $DB->get_records('task_log', [
'classname' => $classname,
], 'timestart DESC', 'id', 0, $retaincount);
$notinsql = "";
if ($keeplogs) {
list($notinsql, $params) = $DB->get_in_or_equal($keeplogs, SQL_PARAMS_NAMED, 'p', false);
$params['classname'] = $classname;
$notinsql = " AND id {$notinsql}";
if ($keeplogs) {
list($notinsql, $params) = $DB->get_in_or_equal(array_keys($keeplogs), SQL_PARAMS_NAMED, 'p', false);
$params['classname'] = $classname;
$notinsql = " AND id {$notinsql}";
}
}
$logids = $DB->get_fieldset_select('task_log', 'id', "classname = :classname {$notinsql}", $params);