MDL-71898 mod_quiz: escape user identity fields on override pages.
This commit is contained in:
committed by
Eloy Lafuente (stronk7)
parent
ee4a1fb8d4
commit
9360ddef14
@@ -236,7 +236,7 @@ class quiz_override_form extends moodleform {
|
||||
$namefields = [];
|
||||
foreach ($extrauserfields as $field) {
|
||||
if (isset($user->$field) && $user->$field !== '') {
|
||||
$namefields[] = $user->$field;
|
||||
$namefields[] = s($user->$field);
|
||||
}
|
||||
}
|
||||
if ($namefields) {
|
||||
|
||||
@@ -103,7 +103,7 @@ if ($override->groupid) {
|
||||
// TODO Does not support custom user profile fields (MDL-70456).
|
||||
foreach (\core_user\fields::for_identity($context, false)->get_required_fields() as $field) {
|
||||
if (isset($user->$field) && $user->$field !== '') {
|
||||
$namefields[] = $user->$field;
|
||||
$namefields[] = s($user->$field);
|
||||
}
|
||||
}
|
||||
if ($namefields) {
|
||||
|
||||
@@ -242,7 +242,7 @@ foreach ($overrides as $override) {
|
||||
foreach ($extrauserfields as $field) {
|
||||
$usercell = new html_table_cell();
|
||||
$usercell->rowspan = count($fields);
|
||||
$usercell->text = $override->$field;
|
||||
$usercell->text = s($override->$field);
|
||||
$usercells[] = $usercell;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user