L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-12647 - Moving multiple_choice questions between contexts breaks them.

Browse Source 
There was a subtle interaction between get_question_options  and replace_file_links for this question type.

Merged from MOODLE_19_STABLE.
This commit is contained in:
tjhunt
2007-12-19 12:11:03 +00:00
parent 8e4636c26f
commit 9088c6e2e4
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/type/multichoice/questiontype.php
+10 -5
View File
@@ -641,13 +641,18 @@ class question_multichoice_qtype extends default_questiontype {
function replace_file_links($question, $fromcourseid, $tocourseid, $url, $destination){
parent::replace_file_links($question, $fromcourseid, $tocourseid, $url, $destination);
// replace links in the question_match_sub table.
// We need to use a separate object, because in load_question_options, $question->options->answers
// is changed from a comma-separated list of ids to an array, so calling update_record on
// $question->options stores 'Array' in that column, breaking the question.
$optionschanged = false;
$question->options->correctfeedback = question_replace_file_links_in_html($question->options->correctfeedback, $fromcourseid, $tocourseid, $url, $destination, $optionschanged);
$question->options->partiallycorrectfeedback = question_replace_file_links_in_html($question->options->partiallycorrectfeedback, $fromcourseid, $tocourseid, $url, $destination, $optionschanged);
$question->options->incorrectfeedback = question_replace_file_links_in_html($question->options->incorrectfeedback, $fromcourseid, $tocourseid, $url, $destination, $optionschanged);
$newoptions = new stdClass;
$newoptions->id = $question->options->id;
$newoptions->correctfeedback = question_replace_file_links_in_html($question->options->correctfeedback, $fromcourseid, $tocourseid, $url, $destination, $optionschanged);
$newoptions->partiallycorrectfeedback = question_replace_file_links_in_html($question->options->partiallycorrectfeedback, $fromcourseid, $tocourseid, $url, $destination, $optionschanged);
$newoptions->incorrectfeedback = question_replace_file_links_in_html($question->options->incorrectfeedback, $fromcourseid, $tocourseid, $url, $destination, $optionschanged);
if ($optionschanged){
if (!update_record('question_multichoice', addslashes_recursive($question->options))) {
error('Couldn\'t update \'question_multichoice\' record '.$question->options->id);
if (!update_record('question_multichoice', addslashes_recursive($newoptions))) {
error('Couldn\'t update \'question_multichoice\' record '.$newoptions->id);
}
}
$answerchanged = false;