MDL-62709 core_message: fix for silently ignored errors in task

2018-06-14 13:19:17 +08:00
parent fd308528cd
commit 904aec69a0
1 changed files with 3 additions and 3 deletions
@@ -90,10 +90,10 @@ class migrate_message_data extends \core\task\adhoc_task {
                            $this->migrate_data($userid, $otheruserid);
                            $transaction->allow_commit();
                        } catch (\Throwable $e) {
-                            $updatepreference = false;
+                            throw $e;
+                        } finally {
+                            $lock->release();
                        }
-
-                        $lock->release();
                    } else {
                        // Couldn't get a lock, move on to next user but make sure we don't update user preference so
                        // we still try again.