L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-34774 Lesson module: fixed report stats for 'high score' and 'low score' values where there is only one attempt with 0 score

Browse Source
This commit is contained in:
Rossiani Wijaya
2013-02-28 16:05:14 +08:00
parent f29e62cb6c
commit 8b8d7fcd17
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/lesson/report.php
+12 -5
View File
@@ -286,10 +286,10 @@ if ($action === 'delete') {
$numofattempts++;
$avescore += $try["grade"];
$avetime += $timetotake;
if ($try["grade"] > $highscore || $highscore == NULL) {
if ($try["grade"] > $highscore || $highscore === NULL) {
$highscore = $try["grade"];
}
if ($try["grade"] < $lowscore || $lowscore == NULL) {
if ($try["grade"] < $lowscore || $lowscore === NULL) {
$lowscore = $try["grade"];
}
if ($timetotake > $hightime || $hightime == NULL) {
@@ -348,10 +348,10 @@ if ($action === 'delete') {
} else {
$lowtime = format_time($lowtime);
}
if ($highscore == NULL) {
if ($highscore === NULL) {
$highscore = get_string("notcompleted", "lesson");
}
if ($lowscore == NULL) {
if ($lowscore === NULL) {
$lowscore = get_string("notcompleted", "lesson");
}
@@ -364,7 +364,14 @@ if ($action === 'delete') {
$stattable->align = array('center', 'center', 'center', 'center', 'center', 'center');
$stattable->wrap = array('nowrap', 'nowrap', 'nowrap', 'nowrap', 'nowrap', 'nowrap');
$stattable->attributes['class'] = 'standardtable generaltable';
$stattable->data[] = array($avescore.'%', $avetime, $highscore.'%', $lowscore.'%', $hightime, $lowtime);
if (is_numeric($highscore)) {
$highscore .= '%';
}
if (is_numeric($lowscore)) {
$lowscore .= '%';
}
$stattable->data[] = array($avescore.'%', $avetime, $highscore, $lowscore, $hightime, $lowtime);
echo html_writer::table($stattable);
} else if ($action === 'reportdetail') {