MDL-33793: Add conditions to the assignment upgrade code to prevent overwriting grade items.

This commit is contained in:
Damyon Wiese
2012-06-17 22:41:59 +08:00
parent 85c4758c5a
commit 8b2cfdc1c6
+4 -4
View File
@@ -221,8 +221,8 @@ class assign_upgrade_manager {
$newassignment->update_calendar($newcoursemodule->id);
// copy the grades from the old assignment to the new one
$DB->set_field('grade_items', 'itemmodule', 'assign', array('iteminstance'=>$oldassignment->id));
$DB->set_field('grade_items', 'iteminstance', $newassignment->get_instance()->id, array('iteminstance'=>$oldassignment->id));
$DB->set_field('grade_items', 'itemmodule', 'assign', array('iteminstance'=>$oldassignment->id, 'itemmodule'=>'assignment'));
$DB->set_field('grade_items', 'iteminstance', $newassignment->get_instance()->id, array('iteminstance'=>$oldassignment->id, 'itemmodule'=>'assign'));
$gradesdone = true;
} catch (Exception $exception) {
@@ -234,8 +234,8 @@ class assign_upgrade_manager {
// roll back the grades changes
if ($gradesdone) {
// copy the grades from the old assignment to the new one
$DB->set_field('grade_items', 'itemmodule', 'assignment', array('iteminstance'=>$newassignment->get_instance()->id));
$DB->set_field('grade_items', 'iteminstance', $oldassignment->id, array('iteminstance'=>$newassignment->get_instance()->id));
$DB->set_field('grade_items', 'itemmodule', 'assignment', array('iteminstance'=>$newassignment->get_instance()->id, 'itemmodule'=>'assign'));
$DB->set_field('grade_items', 'iteminstance', $oldassignment->id, array('iteminstance'=>$newassignment->get_instance()->id, 'itemmodule'=>'assignment'));
}
// roll back the completion changes
if ($completiondone) {