MDL-12789 - dont unnecessarily iterate over all groups

2008-01-01 23:03:02 +00:00
parent a6c905fdac
commit 8a898cb994
1 changed files with 5 additions and 4 deletions
@@ -188,15 +188,16 @@ function check_entry($form, $course) {
 * @param    password  the submitted enrolment key
 */
 function check_group_entry ($courseid, $password) {
-    $ingroup = false;
-    if (($groups = groups_get_all_groups($courseid))) {
+
+    if ($groups = groups_get_all_groups($courseid)) {
        foreach ($groups as $group) {
            if ( !empty($group->enrolmentkey) and (stripslashes($password) == $group->enrolmentkey) ) {
-                $ingroup = $group->id;
+                return $group->id;
            }
        }
    }
-    return $ingroup;
+
+    return false;
 }