MDL-39761: mod_assign: Always check submission plugin status and visibility.
This commit is contained in:
@@ -3585,10 +3585,12 @@ class assign {
|
||||
}
|
||||
|
||||
if ($submission->status != ASSIGN_SUBMISSION_STATUS_SUBMITTED) {
|
||||
// Give each submission plugin a chance to process the submission
|
||||
// Give each submission plugin a chance to process the submission.
|
||||
$plugins = $this->get_submission_plugins();
|
||||
foreach ($plugins as $plugin) {
|
||||
$plugin->submit_for_grading();
|
||||
if ($plugin->is_enabled() && $plugin->is_visible()) {
|
||||
$plugin->submit_for_grading();
|
||||
}
|
||||
}
|
||||
|
||||
$submission->status = ASSIGN_SUBMISSION_STATUS_SUBMITTED;
|
||||
@@ -4013,7 +4015,7 @@ class assign {
|
||||
$allempty = true;
|
||||
$pluginerror = false;
|
||||
foreach ($this->submissionplugins as $plugin) {
|
||||
if ($plugin->is_enabled()) {
|
||||
if ($plugin->is_enabled() && $plugin->is_visible()) {
|
||||
if (!$plugin->save($submission, $data)) {
|
||||
$notices[] = $plugin->get_error();
|
||||
$pluginerror = true;
|
||||
|
||||
Reference in New Issue
Block a user