L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-54116 block_comments: warnings when commenting outside of a course

Browse Source
This commit is contained in:
Marina Glancy
2016-05-26 10:20:13 +08:00
committed by Cameron Ball
parent 95b82c9dcf
commit 89fba73a45
2 changed files with 22 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
blocks/comments/tests/behat/block_comment_dashboard.feature
+14 -4
View File
@@ -4,16 +4,26 @@ Feature: Enable Block comments on the dashboard and view comments
As a teacher
I can add the comments block to my dashboard
Scenario: Add the comments block on the dashboard and add comments
Background:
Given the following "courses" exist:
| fullname | shortname | category |
| Course 1 | C1 | 0 |
And the following "users" exist:
| username | firstname | lastname | email |
| teacher1 | Teacher | Frist | teacher1@example.com |
And I log in as "teacher1"
Scenario: Add the comments block on the dashboard and add comments with Javascript disabled
When I log in as "teacher1"
And I press "Customise this page"
And I add the "Comment" block
And I add the "Comments" block
And I follow "Show comments"
When I add "I'm a comment from the teacher" comment to comments block
And I add "I'm a comment from the teacher" comment to comments block
Then I should see "I'm a comment from the teacher"
@javascript
Scenario: Add the comments block on the dashboard and add comments with Javascript enabled
When I log in as "teacher1"
And I press "Customise this page"
And I add the "Comments" block
And I add "I'm a comment from the teacher" comment to comments block
Then I should see "I'm a comment from the teacher"
comment/comment_post.php
+8 -1
View File
@@ -34,6 +34,11 @@ list($context, $course, $cm) = get_context_info_array($contextid);
require_login($course, true, $cm);
require_sesskey();
if (!$course) {
// Require_login() does not set context if called without a $course, do it manually.
$PAGE->set_context($context);
}
$action = optional_param('action', '', PARAM_ALPHA);
$area = optional_param('area', '', PARAM_AREA);
$content = optional_param('content', '', PARAM_RAW);
@@ -48,7 +53,9 @@ if ($action !== 'add') {
$cmt = new stdClass;
$cmt->contextid = $contextid;
$cmt->courseid = $course->id;
if ($course) {
$cmt->courseid = $course->id;
}
$cmt->cm = $cm;
$cmt->area = $area;
$cmt->itemid = $itemid;