L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'MDL-64205-35-sarunconfirmeduser' of git://github.com/mudrd8mz/moodle into MOODLE_35_STABLE

Browse Source
This commit is contained in:
David Monllao
2018-11-26 15:47:53 +01:00
parent e3a1c26bd7 690e03bfea
commit 89d45109aa
3 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/tool/dataprivacy/db/upgrade.php
+14
View File
@@ -262,5 +262,19 @@ function xmldb_tool_dataprivacy_upgrade($oldversion) {
upgrade_plugin_savepoint(true, 2018051413, 'tool', 'dataprivacy');
}
if ($oldversion < 2018051415) {
// Delete orphaned data privacy requests.
$sql = "SELECT r.id
FROM {tool_dataprivacy_request} r LEFT JOIN {user} u ON r.userid = u.id
WHERE u.id IS NULL";
$orphaned = $DB->get_fieldset_sql($sql);
if ($orphaned) {
$DB->delete_records_list('tool_dataprivacy_request', 'id', $orphaned);
}
upgrade_plugin_savepoint(true, 2018051415, 'tool', 'dataprivacy');
}
return true;
}
admin/tool/dataprivacy/version.php
+1 -1
View File
@@ -24,6 +24,6 @@
defined('MOODLE_INTERNAL') || die;
$plugin->version = 2018051414;
$plugin->version = 2018051415;
$plugin->requires = 2018050800; // Moodle 3.5dev (Build 2018031600) and upwards.
$plugin->component = 'tool_dataprivacy';
lib/classes/task/delete_unconfirmed_users_task.php
+2 -3
View File
@@ -54,9 +54,8 @@ class delete_unconfirmed_users_task extends scheduled_task {
WHERE confirmed = 0 AND timecreated > 0
AND timecreated < ? AND deleted = 0", array($cuttime));
foreach ($rs as $user) {
delete_user($user); // We MUST delete user properly first.
$DB->delete_records('user', array('id' => $user->id)); // This is a bloody hack, but it might work.
mtrace(" Deleted unconfirmed user for ".fullname($user, true)." ($user->id)");
delete_user($user);
mtrace(" Deleted unconfirmed user ".fullname($user, true)." ($user->id)");
}
$rs->close();
}