MDL-40472: Clean all codechecker warnings on mod_assign

mod/assign/db/upgrade.php

@@ -221,7 +221,8 @@ function xmldb_assign_upgrade($oldversion) {
         if (!$dbman->field_exists($table, $field)) {
             // OK safe to cleanup duplicates here.
 
-            $sql = 'SELECT assignment, userid, groupid from {assign_submission} GROUP BY assignment, userid, groupid HAVING (count(id) > 1)';
+            $sql = 'SELECT assignment, userid, groupid from {assign_submission} ' .
+                   'GROUP BY assignment, userid, groupid HAVING (count(id) > 1)';
             $badrecords = $DB->get_recordset_sql($sql);
 
             foreach ($badrecords as $badrecord) {
@@ -424,7 +425,6 @@ function xmldb_assign_upgrade($oldversion) {
     // Moodle v2.5.0 release upgrade line.
     // Put any upgrade step following this.
 
-
     return true;
 }
 

mod/assign/feedback/comments/db/upgrade.php

@@ -38,8 +38,5 @@ function xmldb_assignfeedback_comments_upgrade($oldversion) {
     // Moodle v2.5.0 release upgrade line.
     // Put any upgrade step following this.
 
-
     return true;
 }
-
-

mod/assign/feedback/file/db/upgrade.php

@@ -38,8 +38,5 @@ function xmldb_assignfeedback_file_upgrade($oldversion) {
     // Moodle v2.5.0 release upgrade line.
     // Put any upgrade step following this.
 
-
     return true;
 }
-
-

mod/assign/submission/comments/db/upgrade.php

@@ -37,7 +37,6 @@ function xmldb_assignsubmission_comments_upgrade($oldversion) {
     // Moodle v2.5.0 release upgrade line.
     // Put any upgrade step following this.
 
-
     return true;
 }
 

mod/assign/submission/file/db/upgrade.php

@@ -35,8 +35,5 @@ function xmldb_assignsubmission_file_upgrade($oldversion) {
     // Moodle v2.5.0 release upgrade line.
     // Put any upgrade step following this.
 
-
     return true;
 }
-
-

mod/assign/submission/onlinetext/db/upgrade.php

@@ -37,7 +37,6 @@ function xmldb_assignsubmission_onlinetext_upgrade($oldversion) {
     // Moodle v2.5.0 release upgrade line.
     // Put any upgrade step following this.
 
-
     return true;
 }
 

mod/assign/tests/externallib_test.php

@@ -111,7 +111,7 @@ class mod_assign_external_testcase extends externallib_advanced_testcase {
         $this->assertEquals(1, count($assignment['grades']));
         $grade = $assignment['grades'][0];
         $this->assertEquals($student->id, $grade['userid']);
-        // Should be the last grade (not the first)
+        // Should be the last grade (not the first).
         $this->assertEquals(75, $grade['grade']);
     }
 

mod/assign/tests/locallib_test.php

@@ -739,9 +739,6 @@ class mod_assign_locallib_testcase extends mod_assign_base_testcase {
 
         $grades = $assign->get_user_grades_for_gradebook($this->students[0]->id);
         $this->assertEquals(50, (int)$grades[$this->students[0]->id]->rawgrade);
-
-
     }
-
 }