L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing behavior of (de)select all commands and some issues with non-JS-enabled clients.

Browse Source
This commit is contained in:
defacer
2005-03-18 14:23:45 +00:00
parent 3e03850949
commit 88b917d614
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/quiz/report/overview/report.php
+5 -5
View File
@@ -208,6 +208,7 @@ class quiz_report extends quiz_default_report {
}
echo '<script type="text/javascript" src="'.$CFG->wwwroot.'/mod/quiz/report/overview/utility.js"></script>';
echo '<div id="tablecontainer">';
echo '<form id="attemptsform" method="post" action="report.php" onsubmit="var menu = document.getElementById(\'actionmenu\'); return confirm_if(menu.options[menu.selectedIndex].value == \'delete\', \''.$strreallydel.'\');">';
echo '<input type="hidden" name="id" value="'.$cm->id.'" />';
@@ -216,7 +217,6 @@ class quiz_report extends quiz_default_report {
$table->print_html();
if(!empty($attempts)) {
//There might be a more elegant way than using the <center> tag for this
echo '<table id="commands">';
echo '<tr><td>';
echo '<a href="javascript:select_all();">'.get_string('selectall', 'quiz').'</a> / ';
@@ -225,11 +225,11 @@ class quiz_report extends quiz_default_report {
$options = array('dummy' => ' ', 'delete' => get_string('delete'));
$menu = str_replace('<select', '<select id="actionmenu"', choose_from_menu($options, 'action', '', get_string('selectedattempts', 'quiz'), 'if(this.selectedIndex > 1) submitFormById(\'attemptsform\');', '', true));
echo $menu;
echo '<noscript id="noscriptactionmenu" style="display: inline;">';
echo '<input type="submit" value="'.get_string('go').'" /></noscript>';
echo '<script type="text/javascript">'."\n<!--\n".'document.getElementById("noscriptactionmenu").style.display = "none";'."\n-->\n".'</script>';
echo '</td></tr></table>';
//echo '<noscript id="noscriptactionmenu" style="display: inline;">';
//echo '<input type="submit" value="'.get_string('go').'" /></noscript>';
//echo '<script type="text/javascript">'."\n<!--\n".'document.getElementById("noscriptactionmenu").style.display = "none";'."\n-->\n".'</script>';
echo '</form>';
echo '</form></div>';
}
else {
print_heading(get_string('noattemptsmatchingfilter', 'quiz', strtolower($course->students)));
mod/quiz/report/overview/utility.js
+2
View File
@@ -1,5 +1,6 @@
function select_all() {
var inputs = document.getElementsByTagName('INPUT');
inputs = filterByParent(inputs, function(el) {return findParentNode(el, 'DIV', null, 'tablecontainer');});
for(var i = 0; i < inputs.length; ++i) {
if(inputs[i].type == 'checkbox') {
inputs[i].checked = 'checked';
@@ -9,6 +10,7 @@ function select_all() {
function deselect_all() {
var inputs = document.getElementsByTagName('INPUT');
inputs = filterByParent(inputs, function(el) {return findParentNode(el, 'DIV', null, 'tablecontainer');});
for(var i = 0; i < inputs.length; ++i) {
if(inputs[i].type == 'checkbox') {
inputs[i].checked = '';