MDL-31998 mod_feedback - Feedback depend questions bug

2014-06-13 01:44:35 +02:00
parent 89c7782a91
commit 87aa044351
1 changed files with 16 additions and 0 deletions
@@ -2216,6 +2216,22 @@ function feedback_check_values($firstitem, $lastitem) {
        }
        $value = $itemobj->clean_input_value($value);

+        // If the item is not visible due to its dependency so it shouldn't be required.
+        // Many thanks to Pau Ferrer Ocaña.
+        if ($item->dependitem > 0 AND $item->required == 1) {
+            $comparevalue = false;
+            if ($feedbackcompletedtmp = feedback_get_current_completed($item->feedback, true)) {
+                $comparevalue = feedback_compare_item_value($feedbackcompletedtmp->id,
+                                                            $item->dependitem,
+                                                            $item->dependvalue,
+                                                            true);
+            }
+
+            if (!$comparevalue) {
+                $item->required = 0; // Override the required property.
+            }
+        }
+
        //check if the value is set
        if (is_null($value) AND $item->required == 1) {
            return false;