L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-59691 assignfeedback_editpdf: Allow comments to collapse to top-left

Browse Source 
Forcing them to collapse to the bottom-left corner seems less natural
and effectively changes the location of existing comments from pre-3.3
This commit is contained in:
Tony Butler
2018-04-09 16:56:35 +01:00
parent 14fc7f597a
commit 8531f802ec
4 changed files with 8 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor-debug.js
Vendored
+1 -5
View File
@@ -2592,11 +2592,7 @@ var COMMENT = function(editor, gradeid, pageno, x, y, width, colour, rawtext) {
'height': scrollheight + 'px',
'overflow': 'hidden'
});
marker.setStyles({
'position': 'absolute',
'bottom': 0 - scrollheight + 'px',
'color': COMMENTCOLOUR[this.colour]
});
marker.setStyle('color', COMMENTCOLOUR[this.colour]);
this.attach_events(node, menu);
if (focus) {
node.focus();
mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor-min.js
Vendored
+5 -5
View File
File diff suppressed because one or more lines are too long
mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor.js
Vendored
+1 -5
View File
@@ -2592,11 +2592,7 @@ var COMMENT = function(editor, gradeid, pageno, x, y, width, colour, rawtext) {
'height': scrollheight + 'px',
'overflow': 'hidden'
});
marker.setStyles({
'position': 'absolute',
'bottom': 0 - scrollheight + 'px',
'color': COMMENTCOLOUR[this.colour]
});
marker.setStyle('color', COMMENTCOLOUR[this.colour]);
this.attach_events(node, menu);
if (focus) {
node.focus();
mod/assign/feedback/editpdf/yui/src/editor/js/comment.js
Vendored
+1 -5
View File
@@ -215,11 +215,7 @@ var COMMENT = function(editor, gradeid, pageno, x, y, width, colour, rawtext) {
'height': scrollheight + 'px',
'overflow': 'hidden'
});
marker.setStyles({
'position': 'absolute',
'bottom': 0 - scrollheight + 'px',
'color': COMMENTCOLOUR[this.colour]
});
marker.setStyle('color', COMMENTCOLOUR[this.colour]);
this.attach_events(node, menu);
if (focus) {
node.focus();