L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-59619 mod_data: Fix get_fields WS for databases without fields

Browse Source
This commit is contained in:
Juan Leyva
2017-07-25 14:45:10 +02:00
parent 16a68a2f76
commit 84c2a87b80
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/data/classes/external.php
+1 -1
View File
@@ -596,7 +596,7 @@ class mod_data_external extends external_api {
$params = array('databaseid' => $databaseid);
$params = self::validate_parameters(self::get_fields_parameters(), $params);
$warnings = array();
$fields = $warnings = array();
list($database, $course, $cm, $context) = self::validate_database($params['databaseid']);
mod/data/tests/externallib_test.php
+12
View File
@@ -659,6 +659,18 @@ class mod_data_external_testcase extends externallib_advanced_testcase {
}
}
/**
* Test get_fields_database_without_fields.
*/
public function test_get_fields_database_without_fields() {
$this->setUser($this->student1);
$result = mod_data_external::get_fields($this->database->id);
$result = external_api::clean_returnvalue(mod_data_external::get_fields_returns(), $result);
$this->assertEmpty($result['fields']);
}
/**
* Test search_entries.
*/