L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-62241 privacy: Do not use scalar type hinting on 3.3 branch

Browse Source 
The tests do not actually do anything, they just make sure that the
method signature is correct on the given PHP version.
This commit is contained in:
David Mudrák
2018-04-27 15:20:03 +02:00
parent 48ab35f25d
commit 8460b91e31
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
privacy/classes/manager.php
+2 -2
View File
@@ -355,7 +355,7 @@ class manager {
* @param string $methodname The method to call
* @param array $params The params to call
*/
public static function plugintype_class_callback(string $plugintype, string $interface, string $methodname, array $params) {
public static function plugintype_class_callback($plugintype, $interface, $methodname, array $params) {
$components = \core_component::get_plugin_list($plugintype);
foreach (array_keys($components) as $component) {
static::component_class_callback("{$plugintype}_{$component}", $interface, $methodname, $params);
@@ -371,7 +371,7 @@ class manager {
* @param array $params The params to call
* @return mixed
*/
public static function component_class_callback(string $component, string $interface, string $methodname, array $params) {
public static function component_class_callback($component, $interface, $methodname, array $params) {
$classname = static::get_provider_classname_for_component($component);
if (class_exists($classname) && is_subclass_of($classname, $interface)) {
return component_class_callback($classname, $methodname, $params);
privacy/tests/manager_test.php
+14
View File
@@ -213,4 +213,18 @@ class privacy_manager_testcase extends advanced_testcase {
$this->expectException(\coding_exception::class);
$string = $manager->get_null_provider_reason('mod_testcomponent');
}
/**
* Test that manager::plugintype_class_callback() can be executed.
*/
public function test_plugintype_class_callback() {
\core_privacy\manager::plugintype_class_callback('doesnotexist', 'unusable', 'foo', ['bar']);
}
/**
* Test that manager::component_class_callback() can be executed.
*/
public function test_component_class_callback() {
\core_privacy\manager::component_class_callback('foo_bar', 'unusable', 'foo', ['bar']);
}
}