L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-84532 qtype_ordering: Update query to use $DB->sql_compare_text()

Browse Source 
The change introduced in MDL-46739, which modified the 'value' column in
the 'user_preferences' database table from CHAR to TEXT, caused the
upgrade query to fail due to the '=' comparison operator being used on
this column in the WHERE clause. This fix updates the query to use
$DB->sql_compare_text() instead.
This commit is contained in:
Mihail Geshoski
2025-02-21 12:29:33 +08:00
parent 8f7626c27d
commit 8387b02821
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/type/ordering/db/upgrade.php
+6 -4
View File
@@ -319,8 +319,9 @@ function xmldb_qtype_ordering_upgrade($oldversion) {
// Currently, a 'qtype_ordering_selectcount' user preference is set (or updated, if it already exists) each time
// a new ordering question is created. If there are user preferences that store the removed "0" (all) option, they
// need to be updated. In this case, replace it with "2" (minimum number of items required to create a subset).
$DB->set_field('user_preferences', 'value', 2,
['name' => 'qtype_ordering_selectcount', 'value' => 0]);
$wheresql = 'name = ? AND ' . $DB->sql_compare_text('value') . ' = ?';
$params = ['qtype_ordering_selectcount', '0'];
$DB->set_field_select('user_preferences', 'value', 2, $wheresql, $params);
upgrade_plugin_savepoint(true, 2023092911, 'qtype', 'ordering');
}
@@ -359,8 +360,9 @@ function xmldb_qtype_ordering_upgrade($oldversion) {
// Currently, a 'qtype_ordering_selectcount' user preference is set (or updated, if it already exists) each time
// a new ordering question is created. If there are user preferences that store the removed "0" (all) option, they
// need to be updated. In this case, replace it with "2" (minimum number of items required to create a subset).
$DB->set_field('user_preferences', 'value', 2,
['name' => 'qtype_ordering_selectcount', 'value' => 0]);
$wheresql = 'name = ? AND ' . $DB->sql_compare_text('value') . ' = ?';
$params = ['qtype_ordering_selectcount', '0'];
$DB->set_field_select('user_preferences', 'value', 2, $wheresql, $params);
upgrade_plugin_savepoint(true, 2024040401, 'qtype', 'ordering');
}