L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-70772 mod_forum: check for valid usernode before making active.

Browse Source
This commit is contained in:
Paul Holden
2021-04-14 09:20:26 +01:00
parent 30e6bf75dd
commit 82d35db47a
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/forum/user.php
+10 -6
View File
@@ -164,8 +164,9 @@ if (empty($result->posts)) {
// Edit navbar.
if (isset($courseid) && $courseid != SITEID) {
// Create as much of the navbar automatically.
$newusernode = $PAGE->navigation->find('user' . $user->id, null);
$newusernode->make_active();
if ($newusernode = $PAGE->navigation->find('user' . $user->id, null)) {
$newusernode->make_active();
}
// Check to see if this is a discussion or a post.
if ($mode == 'posts') {
$navbar = $PAGE->navbar->add(get_string('posts', 'forum'), new moodle_url('/mod/forum/user.php',
@@ -182,8 +183,9 @@ if (empty($result->posts)) {
// Edit navbar.
if (isset($courseid) && $courseid != SITEID) {
// Create as much of the navbar automatically.
$usernode = $PAGE->navigation->find('user' . $user->id, null);
$usernode->make_active();
if ($usernode = $PAGE->navigation->find('user' . $user->id, null)) {
$usernode->make_active();
}
// Check to see if this is a discussion or a post.
if ($mode == 'posts') {
$navbar = $PAGE->navbar->add(get_string('posts', 'forum'), new moodle_url('/mod/forum/user.php',
@@ -295,8 +297,10 @@ $PAGE->navigation->set_userid_for_parent_checks($user->id); // see MDL-25805 for
// Edit navbar.
if (isset($courseid) && $courseid != SITEID) {
$usernode = $PAGE->navigation->find('user' . $user->id , null);
$usernode->make_active();
if ($usernode = $PAGE->navigation->find('user' . $user->id , null)) {
$usernode->make_active();
}
// Check to see if this is a discussion or a post.
if ($mode == 'posts') {
$navbar = $PAGE->navbar->add(get_string('posts', 'forum'), new moodle_url('/mod/forum/user.php',