L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-33471 quiz cron: better mtrace output for overdue handling

Browse Source
This commit is contained in:
Tim Hunt
2012-06-08 16:02:01 +01:00
parent 4db061680e
commit 815fcecc40
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/quiz/cronlib.php
+6
View File
@@ -43,6 +43,7 @@ class mod_quiz_overdue_attempt_updater {
* @param int $processfrom the value of $processupto the last time update_overdue_attempts was
* called called and completed successfully.
* @param int $processto only process attempt modifed longer ago than this.
* @return array with two elements, the number of attempt considered, and how many different quizzes that was.
*/
public function update_overdue_attempts($timenow, $processfrom, $processto) {
global $DB;
@@ -53,11 +54,14 @@ class mod_quiz_overdue_attempt_updater {
$quiz = null;
$cm = null;
$count = 0;
$quizcount = 0;
foreach ($attemptstoprocess as $attempt) {
// If we have moved on to a different quiz, fetch the new data.
if (!$quiz || $attempt->quiz != $quiz->id) {
$quiz = $DB->get_record('quiz', array('id' => $attempt->quiz), '*', MUST_EXIST);
$cm = get_coursemodule_from_instance('quiz', $attempt->quiz);
$quizcount += 1;
}
// If we have moved on to a different course, fetch the new data.
@@ -73,9 +77,11 @@ class mod_quiz_overdue_attempt_updater {
// Trigger any transitions that are required.
$attemptobj = new quiz_attempt($attempt, $quizforuser, $cm, $course);
$attemptobj->handle_if_time_expired($timenow, false);
$count += 1;
}
$attemptstoprocess->close();
return array($count, $quizcount);
}
/**
mod/quiz/lib.php
+7 -1
View File
@@ -446,6 +446,7 @@ function quiz_user_complete($course, $user, $mod, $quiz) {
*/
function quiz_cron() {
global $CFG;
mtrace('');
// Since the quiz specifies $module->cron = 60, so that the subplugins can
// have frequent cron if they need it, we now need to do our own scheduling.
@@ -461,10 +462,15 @@ function quiz_cron() {
$overduehander = new mod_quiz_overdue_attempt_updater();
$processto = $timenow - $quizconfig->graceperiodmin;
$overduehander->update_overdue_attempts($timenow, $quizconfig->overduedoneto, $processto);
mtrace(' Looking for quiz overdue quiz attempts between ' .
userdate($quizconfig->overduedoneto) . ' and ' . userdate($processto) . '...');
list($count, $quizcount) = $overduehander->update_overdue_attempts($timenow, $quizconfig->overduedoneto, $processto);
set_config('overduelastrun', $timenow, 'quiz');
set_config('overduedoneto', $processto, 'quiz');
mtrace(' Considered ' . $count . ' attempts in ' . $quizcount . ' quizzes.');
}
// Run cron for our sub-plugin types.