L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-83752 workshop: Handle empty feedbackreviewer

Browse Source 
Causes PHP warnings when null on PHP 8.1.

Signed-off-by: Daniel Ziegenberg <[email protected]>
This commit is contained in:
Daniel Ziegenberg
2025-06-24 12:40:53 +02:00
parent 7d9030acd6
commit 815c051cd0
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/workshop/submission.php
+2 -2
View File
@@ -303,7 +303,7 @@ if ($isreviewer) {
echo $output->render($assessment);
if ($workshop->phase == workshop::PHASE_CLOSED) {
if (strlen(trim($userassessment->feedbackreviewer)) > 0) {
if (isset($userassessment->feedbackreviewer) && !empty(trim($userassessment->feedbackreviewer))) {
echo $output->render(new workshop_feedback_reviewer($userassessment));
}
}
@@ -337,7 +337,7 @@ if (has_capability('mod/workshop:viewallassessments', $workshop->context) or ($o
echo $output->render($displayassessment);
if ($workshop->phase == workshop::PHASE_CLOSED and has_capability('mod/workshop:viewallassessments', $workshop->context)) {
if (strlen(trim($assessment->feedbackreviewer)) > 0) {
if (isset($assessment->feedbackreviewer) && !empty(trim($assessment->feedbackreviewer))) {
echo $output->render(new workshop_feedback_reviewer($assessment));
}
}