MDL-73280 reportbuilder: remove profile field column alias.

It's not required, and also could cause issues for fields that
contained differing casing in their shortname.

Co-authored-by: David Matamoros <[email protected]>
This commit is contained in:
Paul Holden
2021-12-09 12:42:40 +00:00
co-authored by David Matamoros
parent 5ee0b620ae
commit 805b9521fc
@@ -133,7 +133,7 @@ class user_profile_fields {
->add_join("LEFT JOIN {user_info_data} {$userinfotablealias} " .
"ON {$userinfotablealias}.userid = {$this->usertablefieldalias} " .
"AND {$userinfotablealias}.fieldid = {$profilefield->fieldid}")
->add_field("{$userinfotablealias}.data", 'profilefield_' . $profilefield->field->shortname)
->add_field("{$userinfotablealias}.data")
->set_type($this->get_user_field_type($profilefield->field->datatype))
->add_callback([$this, 'format_profile_field'], $profilefield);