L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-60637 group: remove useless id number validation on web services

Browse Source
This commit is contained in:
Simey Lameze
2017-11-21 10:02:16 +08:00
parent 665c3ac59c
commit 7f0eba32de
1 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
group/externallib.php
-11
View File
@@ -90,9 +90,6 @@ class core_group_external extends external_api {
if ($DB->get_record('groups', array('courseid'=>$group->courseid, 'name'=>$group->name))) {
throw new invalid_parameter_exception('Group with the same name already exists in the course');
}
if (!empty($group->idnumber) && $DB->count_records('groups', array('idnumber' => $group->idnumber))) {
throw new invalid_parameter_exception('Group with the same idnumber already exists');
}
// now security checks
$context = context_course::instance($group->courseid, IGNORE_MISSING);
@@ -627,9 +624,6 @@ class core_group_external extends external_api {
if ($DB->count_records('groupings', array('courseid'=>$grouping->courseid, 'name'=>$grouping->name))) {
throw new invalid_parameter_exception('Grouping with the same name already exists in the course');
}
if (!empty($grouping->idnumber) && $DB->count_records('groupings', array('idnumber' => $grouping->idnumber))) {
throw new invalid_parameter_exception('Grouping with the same idnumber already exists');
}
// Now security checks .
$context = context_course::instance($grouping->courseid);
@@ -731,11 +725,6 @@ class core_group_external extends external_api {
$DB->count_records('groupings', array('courseid'=>$currentgrouping->courseid, 'name'=>$grouping->name))) {
throw new invalid_parameter_exception('A different grouping with the same name already exists in the course');
}
// Check if the new modified grouping idnumber already exists.
if (!empty($grouping->idnumber) && $grouping->idnumber != $currentgrouping->idnumber &&
$DB->count_records('groupings', array('idnumber' => $grouping->idnumber))) {
throw new invalid_parameter_exception('A different grouping with the same idnumber already exists');
}
$grouping->courseid = $currentgrouping->courseid;