L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-21400 global Y is evil

Browse Source
This commit is contained in:
Petr Skoda
2010-01-24 10:41:15 +00:00
parent 38224dcb60
commit 7e5f3db4d4
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/ajax/ajaxlib.php
+4 -4
View File
@@ -237,9 +237,7 @@ class page_requirements_manager {
// accessibility stuff
$this->skip_link_to('maincontent', get_string('tocontent', 'access'));
// Note that, as a short-cut, the code
// $js = "document.body.className += ' jsenabled';\n";
// is hard-coded in {@link page_requirements_manager::get_top_of_body_code)
// For now include YUI2, this will be removed asap.
$this->yui2_lib('dom'); // needs to be migrated to YUI3 before we release 2.0
$this->yui2_lib('container'); // needs to be migrated to YUI3 before we release 2.0
$this->yui2_lib('connection'); // needs to be migrated to YUI3 before we release 2.0
@@ -912,7 +910,9 @@ class page_requirements_manager {
// the global Y can be used only after it is fully loaded, that means
// from code executed from the following block
$js .= "Y = YUI(M.yui.loader).use('node', function(Y) {\n{$inyuijs}{$ondomreadyjs}{$jsinit}{$handlersjs}\n});";
// TODO: remove global Y, each part needs some other libs, it is loaded asynchronously too,
// it is necessary to pass around the Y manually, that is why the js_init_call() always uses Y as first parameter
$js .= "var Y = YUI(M.yui.loader).use('node', function(Y) {\n{$inyuijs}{$ondomreadyjs}{$jsinit}{$handlersjs}\n});";
$output .= html_writer::script($js);