adding more checks to make sure 1.8 is unicode only MDL-6332

lib/setup.php

@@ -213,6 +213,7 @@ global $HTTPSPAGEREQUIRED;
             set_config('unicodedb', $CFG->unicodedb);
         }
     }
+    
 /// Set the client/server and connection to utf8 if necessary
 /// and configure some other specific variables for each db
     configure_dbconnection();
@@ -637,4 +638,9 @@ $CFG->os = PHP_OS;
         }
     }
 
+/// Moodle 1.8 needs to be run on unicode, kill if not unicodedb
+    if (!$CFG->unicodedb) {
+        print_error('unicoderequired', 'admin');
+    }
+    
 ?>

lib/setuplib.php

@@ -91,13 +91,20 @@ function make_upload_directory($directory, $shownotices=true) {
  */
 function setup_is_unicodedb() {
 
-    global $CFG, $db;
+    global $CFG, $db, $INSTALL;
 
     $unicodedb = false;
+    
+    // Since this function is also used during installation process, i.e. during install.php before $CFG->dbtype is set.
+    // we need to get dbtype from the right variable 
+    if (!empty($INSTALL['dbtype'])) {
+        $dbtype = $INSTALL['dbtype'];
+    } else {
+        $dbtype = $CFG->dbtype;
+    }
 
-    switch ($CFG->dbtype) {
+    switch ($dbtype) {
         case 'mysql':
-        /// Get MySQL character_set_database value
             $rs = $db->Execute("SHOW VARIABLES LIKE 'character_set_database'");
             if ($rs && $rs->RecordCount() > 0) {
                 $records = $rs->GetAssoc(true);