L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-32392 cleanup: adding @todo about unused is_min_version() method

Browse Source
This commit is contained in:
Eloy Lafuente (stronk7)
2012-04-10 21:26:00 +02:00
parent 7475638c2a
commit 7b74fb7071
4 changed files with 25 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/dml/mssql_native_moodle_database.php
+7
View File
@@ -287,6 +287,13 @@ class mssql_native_moodle_database extends moodle_database {
return $info;
}
/**
* Returns if the RDBMS server fulfills the required version
*
* @param string $version version to check against
* @return bool returns if the version is fulfilled (true) or no (false)
* @todo Delete this unused and protected method. MDL-32392
*/
protected function is_min_version($version) {
$server = $this->get_server_info();
$server = $server['version'];
lib/dml/oci_native_moodle_database.php
+7
View File
@@ -296,6 +296,13 @@ class oci_native_moodle_database extends moodle_database {
return $info;
}
/**
* Returns if the RDBMS server fulfills the required version
*
* @param string $version version to check against
* @return bool returns if the version is fulfilled (true) or no (false)
* @todo Delete this unused and protected method. MDL-32392
*/
protected function is_min_version($version) {
$server = $this->get_server_info();
$server = $server['version'];
lib/dml/pgsql_native_moodle_database.php
+7
View File
@@ -251,6 +251,13 @@ class pgsql_native_moodle_database extends moodle_database {
return array('description'=>$info['server'], 'version'=>$info['server']);
}
/**
* Returns if the RDBMS server fulfills the required version
*
* @param string $version version to check against
* @return bool returns if the version is fulfilled (true) or no (false)
* @todo Make this method private. MDL-32392
*/
protected function is_min_version($version) {
$server = $this->get_server_info();
$server = $server['version'];
lib/dml/sqlsrv_native_moodle_database.php
+4 -3
View File
@@ -277,10 +277,11 @@ class sqlsrv_native_moodle_database extends moodle_database {
}
/**
* Get the minimum SQL allowed
* Returns if the RDBMS server fulfills the required version
*
* @param mixed $version
* @return mixed
* @param string $version version to check against
* @return bool returns if the version is fulfilled (true) or no (false)
* @todo Delete this unused and protected method. MDL-32392
*/
protected function is_min_version($version) {
$server = $this->get_server_info();