L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-57020 scales: Allow deletion of unused scales in forum

Browse Source 
Allow deletion of unused scales used in a
forum for the course.

Signed-off-by: Sujith Haridasan <[email protected]>
This commit is contained in:
Sujith Haridasan
2021-01-15 15:07:53 +05:30
parent c381757f2a
commit 7b3f43db95
3 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/grade/tests/grade_scale_test.php
+4
View File
@@ -167,5 +167,9 @@ class core_grade_scale_testcase extends grade_base_testcase {
$this->assertNotEmpty($grade_item->id);
$this->assertEquals(1, $grade_item->grademin);
$this->assertEquals(1, $grade_item->grademax);
$status = $scale->is_used();
$this->assertTrue($status);
}
}
mod/forum/lib.php
+1 -1
View File
@@ -954,7 +954,7 @@ function forum_scale_used_anywhere(int $scaleid): bool {
return false;
}
return $DB->record_exists('forum', ['scale' => $scaleid * -1]);
return $DB->record_exists_select('forum', "scale = ? and assessed > 0", [$scaleid * -1]);
}
// SQL FUNCTIONS ///////////////////////////////////////////////////////////
mod/glossary/lib.php
+1 -1
View File
@@ -877,7 +877,7 @@ function glossary_scale_used() {
function glossary_scale_used_anywhere($scaleid) {
global $DB;
if ($scaleid and $DB->record_exists('glossary', array('scale'=>-$scaleid))) {
if ($scaleid and $DB->record_exists_select('glossary', "scale = ? and assessed > 0", [-$scaleid])) {
return true;
} else {
return false;