L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-53113 libraries: Also remove core_renderer->notify_xxx() methods

Browse Source 
Keeping the methods instead of fully deleting them alternative.
This commit is contained in:
Eloy Lafuente (stronk7)
2018-01-17 02:18:16 +01:00
parent 3becfcd226
commit 76f8b36105
2 changed files with 14 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/outputrenderers.php
+12 -60
View File
@@ -2889,72 +2889,24 @@ EOD;
return $this->render_from_template($notification->get_template_name(), $notification->export_for_template($this));
}
/**
* Output a notification at a particular level - in this case, NOTIFY_PROBLEM.
*
* @param string $message the message to print out
* @return string HTML fragment.
* @deprecated since Moodle 3.1 MDL-30811 - please do not use this function any more.
* @todo MDL-53113 This will be removed in Moodle 3.5.
* @see \core\output\notification
*/
public function notify_problem($message) {
debugging(__FUNCTION__ . ' is deprecated.' .
'Please use \core\notification::add, or \core\output\notification as required',
DEBUG_DEVELOPER);
$n = new \core\output\notification($message, \core\output\notification::NOTIFY_ERROR);
return $this->render($n);
public function notify_problem() {
throw new coding_exception('core_renderer::notify_problem() can not be used any more, '.
'please use \core\notification::add(), or \core\output\notification as required.');
}
/**
* Output a notification at a particular level - in this case, NOTIFY_SUCCESS.
*
* @param string $message the message to print out
* @return string HTML fragment.
* @deprecated since Moodle 3.1 MDL-30811 - please do not use this function any more.
* @todo MDL-53113 This will be removed in Moodle 3.5.
* @see \core\output\notification
*/
public function notify_success($message) {
debugging(__FUNCTION__ . ' is deprecated.' .
'Please use \core\notification::add, or \core\output\notification as required',
DEBUG_DEVELOPER);
$n = new \core\output\notification($message, \core\output\notification::NOTIFY_SUCCESS);
return $this->render($n);
public function notify_success() {
throw new coding_exception('core_renderer::notify_success() can not be used any more, '.
'please use \core\notification::add(), or \core\output\notification as required.');
}
/**
* Output a notification at a particular level - in this case, NOTIFY_MESSAGE.
*
* @param string $message the message to print out
* @return string HTML fragment.
* @deprecated since Moodle 3.1 MDL-30811 - please do not use this function any more.
* @todo MDL-53113 This will be removed in Moodle 3.5.
* @see \core\output\notification
*/
public function notify_message($message) {
debugging(__FUNCTION__ . ' is deprecated.' .
'Please use \core\notification::add, or \core\output\notification as required',
DEBUG_DEVELOPER);
$n = new \core\output\notification($message, \core\output\notification::NOTIFY_INFO);
return $this->render($n);
public function notify_message() {
throw new coding_exception('core_renderer::notify_message() can not be used any more, '.
'please use \core\notification::add(), or \core\output\notification as required.');
}
/**
* Output a notification at a particular level - in this case, NOTIFY_REDIRECT.
*
* @param string $message the message to print out
* @return string HTML fragment.
* @deprecated since Moodle 3.1 MDL-30811 - please do not use this function any more.
* @todo MDL-53113 This will be removed in Moodle 3.5.
* @see \core\output\notification
*/
public function notify_redirect($message) {
debugging(__FUNCTION__ . ' is deprecated.' .
'Please use \core\notification::add, or \core\output\notification as required',
DEBUG_DEVELOPER);
$n = new \core\output\notification($message, \core\output\notification::NOTIFY_INFO);
return $this->render($n);
public function notify_redirect() {
throw new coding_exception('core_renderer::notify_redirect() can not be used any more, '.
'please use \core\notification::add(), or \core\output\notification as required.');
}
/**
lib/upgrade.txt
+2
View File
@@ -3,6 +3,8 @@ information provided here is intended especially for developers.
=== 3.5 ===
* The core_renderer methods notify_problem(), notify_success(), notify_message() and notify_redirect() that were
deprecated in Moodle 3.1 have been removed. Use \core\notification::add(), or \core\output\notification as required.
* The maximum supported precision (the total number of digits) for XMLDB_TYPE_NUMBER ("number") fields raised from 20 to
38 digits. Additionally, the whole number part (precision minus scale) must not be longer than the maximum length of
integer fields (20 digits). Note that PHP floats commonly support precision of roughly 15 digits only (MDL-32113).