lesson MDL-26768 lesson was inserting a grade of 0 when a user id and a null raw grade were supplied

2011-03-16 10:26:12 +08:00
parent 2b37004c28
commit 76027a9f65
1 changed files with 7 additions and 1 deletions
@@ -487,7 +487,13 @@ function lesson_grade_item_update($lesson, $grades=NULL) {
            if (!is_array($grade)) {
                $grades[$key] = $grade = (array) $grade;
            }
-            $grades[$key]['rawgrade'] = ($grade['rawgrade'] * $lesson->grade / 100);
+            //check raw grade isnt null otherwise we erroneously insert a grade of 0
+            if ($grade['rawgrade'] !== null) {
+                $grades[$key]['rawgrade'] = ($grade['rawgrade'] * $lesson->grade / 100);
+            } else {
+                //setting rawgrade to null just in case user is deleting a grade
+                $grades[$key]['rawgrade'] = null;
+            }
        }
    }