MDL-35127 Assignment - declare the variables in the outer scope (for readability)

This commit is contained in:
Damyon Wiese
2013-02-27 10:09:33 +08:00
parent a6c54ab297
commit 7215ff4efa
+4 -1
View File
@@ -311,6 +311,8 @@ function assign_print_overview($courses, &$htmlarray) {
// NOTE: we do all possible database work here *outside* of the loop to ensure this scales
//
list($sqlassignmentids, $assignmentidparams) = $DB->get_in_or_equal($assignmentids);
$mysubmissions = null;
$unmarkedsubmissions = null;
foreach ($assignments as $assignment) {
// Do not show assignments that are not open
@@ -370,7 +372,8 @@ function assign_print_overview($courses, &$htmlarray) {
$link = new moodle_url('/mod/assign/view.php', array('id'=>$assignment->coursemodule, 'action'=>'grading'));
$str .= '<div class="details"><a href="'.$link.'">'.get_string('submissionsnotgraded', 'assign', $submissions).'</a></div>';
}
} if (has_capability('mod/assign:submit', $context)) {
}
if (has_capability('mod/assign:submit', $context)) {
if (!isset($mysubmissions)) {
// get all user submissions, indexed by assignment id
$mysubmissions = $DB->get_records_sql("SELECT a.id AS assignment, a.nosubmissions AS nosubmissions, g.timemodified