MDL-43714 blocks: fixed notice when moving to an empty region

2014-01-17 10:46:47 +13:00
parent 6370d316fd
commit 70c46470fe
1 changed files with 8 additions and 3 deletions
@@ -88,9 +88,14 @@ switch ($action) {

        $bui_newweight = null;
        if ($bui_beforeid == 0) {
-            // Moving to very bottom
-            $last = end($instances);
-            $bui_newweight = $last->instance->weight + 1;
+            if (count($instances) === 0) {
+                // Moving the block into an empty region. Give it the default weight.
+                $bui_newweight = 0;
+            } else {
+                // Moving to very bottom.
+                $last = end($instances);
+                $bui_newweight = $last->instance->weight + 1;
+            }
        } else {
            // Moving somewhere
            $lastweight = 0;