L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-30911: mod_lesson: fix sub-heading level to be lower than lesson title. This issue is an improvement of accessibility compliance

Browse Source
This commit is contained in:
Rossiani Wijaya
2012-02-13 11:18:39 +08:00
parent 52e6baa94b
commit 6df07690e2
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/lesson/pagetypes/branchtable.php
+2 -1
View File
@@ -110,7 +110,8 @@ class lesson_page_type_branchtable extends lesson_page {
if ($this->lesson->slideshow) {
$output .= $renderer->slideshow_start($this->lesson);
}
$output .= $renderer->heading(format_string($this->properties->title));
// We are using level 3 header because the page title is a sub-heading of lesson title (MDL-30911).
$output .= $renderer->heading(format_string($this->properties->title), 3);
$output .= $renderer->box($this->get_contents(), 'contents');
$buttons = array();
mod/lesson/view.php
+4 -2
View File
@@ -391,7 +391,8 @@ if ($pageid != LESSON_EOL) {
lesson_add_fake_blocks($PAGE, $cm, $lesson, $timer);
echo $lessonoutput->header($lesson, $cm, $currenttab, $extraeditbuttons, $lessonpageid);
if ($attemptflag) {
echo $OUTPUT->heading(get_string('attempt', 'lesson', $retries));
// We are using level 3 header because attempt heading is a sub-heading of lesson title (MDL-30911).
echo $OUTPUT->heading(get_string('attempt', 'lesson', $retries), 3);
}
/// This calculates and prints the ongoing score
if ($lesson->ongoing && !empty($pageid) && !$reviewmode) {
@@ -415,7 +416,8 @@ if ($pageid != LESSON_EOL) {
// Update the clock / get time information for this user
add_to_log($course->id, "lesson", "end", "view.php?id=".$PAGE->cm->id, "$lesson->id", $PAGE->cm->id);
$lessoncontent .= $OUTPUT->heading(get_string("congratulations", "lesson"));
// We are using level 3 header because the page title is a sub-heading of lesson title (MDL-30911).
$lessoncontent .= $OUTPUT->heading(get_string("congratulations", "lesson"), 3);
$lessoncontent .= $OUTPUT->box_start('generalbox boxaligncenter');
$ntries = $DB->count_records("lesson_grades", array("lessonid"=>$lesson->id, "userid"=>$USER->id));
if (isset($USER->modattempts[$lesson->id])) {