Revert "MDL-33212 Course page: Eye icon should override other conditions"

This reverts commit 5d0d373733.

course/lib.php

@@ -1728,7 +1728,7 @@ function print_section($course, $section, $mods, $modnamesused, $absolute=false,
             // see the activity itself, or for staff)
             if (!$mod->uservisible) {
                 echo '<div class="availabilityinfo">'.$mod->availableinfo.'</div>';
-            } else if ($canviewhidden && !empty($CFG->enableavailability) && $mod->visible) {
+            } else if ($canviewhidden && !empty($CFG->enableavailability)) {
                 $ci = new condition_info($mod);
                 $fullinfo = $ci->get_full_information();
                 if($fullinfo) {

lib/conditionlib.php

@@ -846,16 +846,6 @@ abstract class condition_info_base {
             }
         }
 
-        // If the item is marked as 'not visible' then we don't change the available
-        // flag (visible/available are treated distinctly), but we remove any
-        // availability info. If the item is hidden with the eye icon, it doesn't
-        // make sense to show 'Available from <date>' or similar, because even
-        // when that date arrives it will still not be available unless somebody
-        // toggles the eye icon.
-        if (!$this->item->visible) {
-            $information = '';
-        }
-
         $information = trim($information);
         return $available;
     }