L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-60654 calendar: Clean up lines 140-154

Browse Source 
The if+switch code between lines 140 and 154, even though they selected 3 different choices, all of them gave the same result.
Therefore, it'd be cleaner to replace those 16 lines for just two.
This commit is contained in:
João Umberto Ciocca de Almeida
2017-11-08 18:36:03 -02:00
committed by GitHub
parent ccf7578373
commit 6bc8a2e11f
1 changed files with 4 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
calendar/view.php
+4 -15
View File
@@ -123,21 +123,10 @@ echo $renderer->start_layout();
echo html_writer::start_tag('div', array('class'=>'heightcontainer'));
echo $OUTPUT->heading(get_string('calendar', 'calendar'));
if ($view == 'day' || $view == 'upcoming') {
switch($view) {
case 'day':
list($data, $template) = calendar_get_view($calendar, $view);
echo $renderer->render_from_template($template, $data);
break;
case 'upcoming':
list($data, $template) = calendar_get_view($calendar, $view);
echo $renderer->render_from_template($template, $data);
break;
}
} else if ($view == 'month') {
list($data, $template) = calendar_get_view($calendar, $view);
echo $renderer->render_from_template($template, $data);
}
list($data, $template) = calendar_get_view($calendar, $view);
echo $renderer->render_from_template($template, $data);
echo html_writer::end_tag('div');
list($data, $template) = calendar_get_footer_options($calendar);