L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-58096 reports: Optimize database request

Browse Source
This commit is contained in:
Gilles-Philippe Leblanc
2017-04-18 10:59:41 -04:00
parent 6d14355ce8
commit 6a54bd292c
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
report/stats/locallib.php
+10 -1
View File
@@ -85,17 +85,26 @@ function report_stats_report($course, $report, $mode, $user, $roleid, $time) {
$userid = 0;
}
$courses = get_courses('all','c.shortname','c.id,c.shortname,c.fullname');
$courses = $DB->get_recordset('course', null, 'shortname', 'id,shortname,visible');
$courseoptions = array();
foreach ($courses as $c) {
context_helper::preload_from_record($c);
$context = context_course::instance($c->id);
if (has_capability('report/stats:view', $context)) {
if (isset($c->visible) && $c->visible <= 0) {
// For hidden courses, require visibility check.
if (!has_capability('moodle/course:viewhiddencourses', $context)) {
continue;
}
}
$courseoptions[$c->id] = format_string($c->shortname, true, array('context' => $context));
}
}
$courses->close();
$reportoptions = stats_get_report_options($course->id, $mode);
$timeoptions = report_stats_timeoptions($mode);
if (empty($timeoptions)) {