L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-63826 tests: Don't rely on random array keys for testing

Browse Source
This commit is contained in:
Eloy Lafuente (stronk7)
2018-11-01 00:34:55 +01:00
parent 39ce011f9d
commit 6a4e92da5c
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/assign/submission/comments/tests/privacy_test.php
+5 -3
View File
@@ -174,9 +174,11 @@ class assignsubmission_comments_privacy_testcase extends \mod_assign\tests\mod_a
\assignsubmission_comments\privacy\provider::get_userids_from_context($userlist);
$userids = $userlist->get_userids();
$this->assertCount(3, $userids);
// Two is the key for user 3.
$this->assertEquals(2, array_search($user3->id, $userids));
$this->assertFalse(array_search($user4->id, $userids));
// User 1,2 and 3 are the expected ones in the array. User 4 isn't.
$this->assertContains($user1->id, $userids);
$this->assertContains($user2->id, $userids);
$this->assertContains($user3->id, $userids);
$this->assertNotContains($user4->id, $userids);
}
/**