L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-50907 antivirus: Add test coverage for scan_data.

Browse Source
This commit is contained in:
Ruslan Kabalin
2018-04-12 10:30:25 +08:00
committed by Andrew Nicols
parent f6c5cfef77
commit 694cb8eb21
2 changed files with 44 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/tests/antivirus_test.php
+22 -20
View File
@@ -57,11 +57,7 @@ class core_antivirus_testcase extends advanced_testcase {
public function test_manager_scan_file_no_virus() {
// Run mock scanning.
$this->assertFileExists($this->tempfile);
try {
\core\antivirus\manager::scan_file($this->tempfile, 'OK', true);
} catch (\moodle_exception $e) {
$this->fail('Exception scanner_exception is not expected in clean file scanning.');
}
$this->assertEmpty(\core\antivirus\manager::scan_file($this->tempfile, 'OK', true));
// File expected to remain in place.
$this->assertFileExists($this->tempfile);
}
@@ -69,11 +65,7 @@ class core_antivirus_testcase extends advanced_testcase {
public function test_manager_scan_file_error() {
// Run mock scanning.
$this->assertFileExists($this->tempfile);
try {
\core\antivirus\manager::scan_file($this->tempfile, 'ERROR', true);
} catch (\moodle_exception $e) {
$this->fail('Exception scanner_exception is not expected in error file scanning.');
}
$this->assertEmpty(\core\antivirus\manager::scan_file($this->tempfile, 'ERROR', true));
// File expected to remain in place.
$this->assertFileExists($this->tempfile);
}
@@ -81,21 +73,31 @@ class core_antivirus_testcase extends advanced_testcase {
public function test_manager_scan_file_virus() {
// Run mock scanning without deleting infected file.
$this->assertFileExists($this->tempfile);
try {
\core\antivirus\manager::scan_file($this->tempfile, 'FOUND', false);
} catch (\moodle_exception $e) {
$this->assertInstanceOf('\core\antivirus\scanner_exception', $e);
}
$this->expectException(\core\antivirus\scanner_exception::class);
$this->assertEmpty(\core\antivirus\manager::scan_file($this->tempfile, 'FOUND', false));
// File expected to remain in place.
$this->assertFileExists($this->tempfile);
// Run mock scanning with deleting infected file.
try {
\core\antivirus\manager::scan_file($this->tempfile, 'FOUND', true);
} catch (\moodle_exception $e) {
$this->assertInstanceOf('\core\antivirus\scanner_exception', $e);
}
$this->expectException(\core\antivirus\scanner_exception::class);
$this->assertEmpty(\core\antivirus\manager::scan_file($this->tempfile, 'FOUND', true));
// File expected to be deleted.
$this->assertFileNotExists($this->tempfile);
}
public function test_manager_scan_data_no_virus() {
// Run mock scanning.
$this->assertEmpty(\core\antivirus\manager::scan_data('OK'));
}
public function test_manager_scan_data_error() {
// Run mock scanning.
$this->assertEmpty(\core\antivirus\manager::scan_data('ERROR'));
}
public function test_manager_scan_data_virus() {
// Run mock scanning.
$this->expectException(\core\antivirus\scanner_exception::class);
$this->assertEmpty(\core\antivirus\manager::scan_data('FOUND'));
}
}
lib/tests/fixtures/testable_antivirus.php
Vendored
+22
View File
@@ -66,4 +66,26 @@ class scanner extends \core\antivirus\scanner {
break;
}
}
/**
* Scan data.
*
* Provides fake responses for testing \core\antivirus\manager.
*
* @param string $data The variable containing the data to scan.
* @return int Scanning result constant.
*/
public function scan_data($data) {
switch ($data) {
case 'OK':
return self::SCAN_RESULT_OK;
case 'FOUND':
return self::SCAN_RESULT_FOUND;
case 'ERROR':
return self::SCAN_RESULT_ERROR;
default:
debugging('$data should be either OK, FOUND or ERROR.');
break;
}
}
}