L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-30358 forms: strict validation is too strict

Browse Source
This commit is contained in:
Marina Glancy
2014-10-15 11:57:45 +08:00
parent 09d7d68f59
commit 6929837ade
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/formslib.php
+1 -1
View File
@@ -2889,7 +2889,7 @@ class MoodleQuickForm_Rule_Required extends HTML_QuickForm_Rule {
}
$stripvalues = array(
'#</?(?!img|canvas|hr).*?>#im', // all tags except img, canvas and hr
'#(\xc2|\xa0|\s|&nbsp;)#', //any whitespaces actually
'#(\xc2\xa0|\s|&nbsp;)#', // Any whitespaces actually.
);
if (!empty($CFG->strictformsrequired)) {
$value = preg_replace($stripvalues, '', (string)$value);
lib/tests/formslib_test.php
+4
View File
@@ -51,6 +51,8 @@ class core_formslib_testcase extends advanced_testcase {
$this->assertTrue($rule->validate("Something\nmore"));
$this->assertTrue($rule->validate("\nmore"));
$this->assertTrue($rule->validate(" more "));
$this->assertTrue($rule->validate('ш'));
$this->assertTrue($rule->validate("の"));
$this->assertTrue($rule->validate("0"));
$this->assertTrue($rule->validate(0));
$this->assertTrue($rule->validate(true));
@@ -88,6 +90,8 @@ class core_formslib_testcase extends advanced_testcase {
$this->assertTrue($rule->validate("\nmore"));
$this->assertTrue($rule->validate(" more "));
$this->assertTrue($rule->validate("0"));
$this->assertTrue($rule->validate('ш'));
$this->assertTrue($rule->validate("の"));
$this->assertTrue($rule->validate(0));
$this->assertTrue($rule->validate(true));
$this->assertTrue($rule->validate('<p>x</p>'));