L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-50650 core_grades: allow grade imports larger than 100 points

Browse Source
This commit is contained in:
Kyle Matter
2023-12-04 12:34:44 +08:00
committed by Ilya Tregubov
parent abba174fe1
commit 68ef883354
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
grade/import/csv/classes/load_data.php
+3 -6
View File
@@ -159,17 +159,14 @@ class gradeimport_csv_load_data {
$record->userid = $studentid;
$record->importer = $USER->id;
// By default the maximum grade is 100.
$gradepointmaximum = 100;
// If the grade limit has been increased then use the gradepointmax setting.
if ($CFG->unlimitedgrades) {
$gradepointmaximum = $CFG->gradepointmax;
}
// Unlimitedgrades allows for scores over 100%.
// If the record final grade is set then check that the grade value isn't too high.
// Final grade will not be set if we are inserting feedback.
if (!isset($record->finalgrade) || $record->finalgrade <= $gradepointmaximum) {
if (!isset($record->finalgrade) || $record->finalgrade <= $CFG->gradepointmax || $CFG->unlimitedgrades) {
return $DB->insert_record('grade_import_values', $record);
} else {
$this->cleanup_import(get_string('gradevaluetoobig', 'grades', $gradepointmaximum));
$this->cleanup_import(get_string('gradevaluetoobig', 'grades', $CFG->gradepointmax));
return null;
}
}