MDL-47404 filelib: Prevent flash from treating files as uploads

Flash treats files as uploads if filename is passed in content-disposition
this causes security to be enforced that causes issues with SCORM packages
This commit is contained in:
Dan Marsden
2014-09-25 13:22:17 +12:00
parent 8152e9fa60
commit 68406d778c
+4 -1
View File
@@ -2273,7 +2273,10 @@ function send_file($path, $filename, $lifetime = null , $filter=0, $pathisstring
if ($forcedownload) {
header('Content-Disposition: attachment; filename="'.$filename.'"');
} else {
} else if ($mimetype !== 'application/x-shockwave-flash') {
// If this is an swf don't pass content-disposition with filename as this makes the flash player treat the file
// as an upload and enforces security that may prevent the file from being loaded.
header('Content-Disposition: inline; filename="'.$filename.'"');
}