L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-29598 backup Avoid possible future duplicate grade letters

Browse Source 
More info in restore_activity_grades_structure_step->process_grade_letter() comments
This commit is contained in:
David Monllao
2012-08-24 08:54:49 +08:00
parent 5bc8335c6f
commit 67d4424a6b
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backup/moodle2/restore_stepslib.php
+11 -8
View File
@@ -270,10 +270,9 @@ class restore_gradebook_structure_step extends restore_structure_step {
$data->contextid = context_course::instance($this->get_courseid())->id;
// MDL-29598 - Don't insert a duplicate record if this grade letter already exists
$gltest = (array)$data;
unset($gltest['id']);
if (!$DB->record_exists('grade_letters', $gltest)) {
$gradeletter = (array)$data;
unset($gradeletter['id']);
if (!$DB->record_exists('grade_letters', $gradeletter)) {
$newitemid = $DB->insert_record('grade_letters', $data);
} else {
$newitemid = $data->id;
@@ -2407,17 +2406,21 @@ class restore_activity_grades_structure_step extends restore_structure_step {
/**
* process activity grade_letters. Note that, while these are possible,
* because grade_letters are contextid based, in proctice, only course
* because grade_letters are contextid based, in practice, only course
* context letters can be defined. So we keep here this method knowing
* it won't be executed ever. gradebook restore will restore course letters.
*/
protected function process_grade_letter($data) {
global $DB;
$data = (object)$data;
$data['contextid'] = $this->task->get_contextid();
$gradeletter = (object)$data;
$data->contextid = $this->task->get_contextid();
$newitemid = $DB->insert_record('grade_letters', $data);
// Check if it exists before adding it
unset($data['id']);
if (!$DB->record_exists('grade_letters', $data)) {
$newitemid = $DB->insert_record('grade_letters', $gradeletter);
}
// no need to save any grade_letter mapping
}
}