MDL-14647 fix legacy add_teacher() when approving new course; backported from HEAD

course/pending.php

@@ -48,7 +48,8 @@
             if ($courseid = insert_record("course",$course)) {
                 $page = page_create_object(PAGE_COURSE_VIEW, $courseid);
                 blocks_repopulate_page($page); // Return value not checked because you can always edit later
-                add_teacher($teacherid,$courseid);
+                $context = get_context_instance(CONTEXT_COURSE, $courseid);
+                role_assign($CFG->creatornewroleid, $teacherid, 0, $context->id); // assing teacher role
                 $course->id = $courseid;
                 if (!empty($CFG->restrictmodulesfor) && $CFG->restrictmodulesfor != 'none' && !empty($CFG->restrictbydefault)) { // if we're all or requested we're ok.
                     $allowedmods = explode(',',$CFG->defaultallowedmodules);