L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qtype admin MDL-25987 use get_plugin_list, rather than including questionlib.php.

Browse Source 
This should be a small be significant performance win for people who are logged in as admin.
This commit is contained in:
Tim Hunt
2011-01-14 17:26:31 +00:00
parent 5a7f931ee5
commit 63b5318e86
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/settings/plugins.php
+5 -6
View File
@@ -372,13 +372,12 @@ if ($hassiteconfig || has_capability('moodle/question:config', $systemcontext))
// Question type settings.
$ADMIN->add('modules', new admin_category('qtypesettings', get_string('questiontypes', 'admin')));
$ADMIN->add('qtypesettings', new admin_page_manageqtypes());
require_once($CFG->libdir . '/questionlib.php');
global $QTYPES;
foreach ($QTYPES as $qtype) {
$settingsfile = $qtype->plugin_dir() . '/settings.php';
$qtypes = get_plugin_list('qtype');
foreach ($qtypes as $qtype => $path) {
$settingsfile = $path . '/settings.php';
if (file_exists($settingsfile)) {
$settings = new admin_settingpage('qtypesetting' . $qtype->name(),
$qtype->local_name(), 'moodle/question:config');
$settings = new admin_settingpage('qtypesetting' . $qtype,
get_string('pluginname', 'qtype_' . $qtype), 'moodle/question:config');
include($settingsfile);
if ($settings) {
$ADMIN->add('qtypesettings', $settings);