MDL-45376 Completion: Form locking is still not working right

On submit of the form, it called 'freeze' on the completion-related
fields (even though they shouldn't have been frozen because you
already clicked the unlock button).
This commit is contained in:
sam marshall
2014-05-01 18:16:14 +01:00
parent a76fb41a02
commit 62e02e583f
+4 -2
View File
@@ -224,8 +224,10 @@ abstract class moodleform_mod extends moodleform {
// is changed, maybe someone has completed it now)
$mform->getElement('completionunlocked')->setValue(1);
} else {
// Has the element been unlocked?
if ($mform->exportValue('unlockcompletion')) {
// Has the element been unlocked, either by the button being pressed
// in this request, or the field already being set from a previous one?
if ($mform->exportValue('unlockcompletion') ||
$mform->exportValue('completionunlocked')) {
// Yes, add in warning text and set the hidden variable
$mform->insertElementBefore(
$mform->createElement('static', 'completedunlocked',