L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NOMDL survey - fix crazy query cross-joining like hell

Browse Source
This commit is contained in:
Eloy Lafuente
2010-07-28 16:02:22 +00:00
parent 84cdf7de51
commit 62ab566eb7
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/survey/lib.php
+7 -4
View File
@@ -381,16 +381,19 @@ function survey_update_analysis($survey, $user, $notes) {
function survey_get_user_answers($surveyid, $questionid, $groupid, $sort="sa.answer1,sa.answer2 ASC") {
global $DB;
$params = array('surveyid'=>$surveyid, 'questionid'=>$questionid, 'groupid'=>$groupid);
$params = array('surveyid'=>$surveyid, 'questionid'=>$questionid);
if ($groupid) {
$groupsql = "AND gm.groupid = :groupid AND u.id = gm.userid";
$groupfrom = ', {groups_members} gm';
$groupsql = 'AND gm.groupid = :groupid AND u.id = gm.userid';
$params['groupid'] = $groupid;
} else {
$groupsql = "";
$groupfrom = '';
$groupsql = '';
}
return $DB->get_records_sql("SELECT sa.*,u.firstname,u.lastname,u.picture
FROM {survey_answers} sa, {user} u, {groups_members} gm
FROM {survey_answers} sa, {user} u $groupfrom
WHERE sa.survey = :surveyid
AND sa.question = :questionid
AND u.id = sa.userid $groupsql