L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-56486 workshop: Do not rely on the button implementation in behat

Browse Source 
It turned out that behat's "I should see ..." does not work for buttons
rendered as `<input>` elements so this assertion worked only in Boost
where the button is rendered as `<button>` but not in Clean.

But we do not really need this check here. All we need is to make sure
that the form has been saved successfully. For which, checking for the
text on the page is enough.

p.s. Another mistake of mine to not double-check behat on both standard
themes. Sigh ...
This commit is contained in:
David Mudrák
2017-07-12 11:58:08 +02:00
parent 581710e278
commit 6218889e2d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/workshop/tests/behat/file_type_restriction.feature
+1 -1
View File
@@ -112,9 +112,9 @@ Feature: File types of the submission and feedback attachments can be limitted
And I press "Update"
When I press "Save and close"
Then I should see "Some files (renamed.png) cannot be uploaded. Only file types .php are allowed."
And I should not see "Assigned submissions to assess"
# Finally make sure that allowed file gets uploaded.
And I delete "renamed.png" from "Attachment" filemanager
And I upload "mod/workshop/tests/fixtures/testable.php" file to "Attachment" filemanager
And I press "Save and close"
And I should see "Assigned submissions to assess"
And I should see "Re-assess"