MDL-45068 groups: corrected check for idnumber '0'

This commit is contained in:
Marina Glancy
2017-11-29 11:54:31 +08:00
parent 108411af39
commit 60770d10f9
+2 -2
View File
@@ -134,7 +134,7 @@ if ($mform_post->is_cancelled()) {
}
}
if (!empty($newgroup->idnumber)) {
if (isset($newgroup->idnumber) && strlen($newgroup->idnumber)) {
//if idnumber is set, we use that.
//unset invalid courseid
if (!$mycourse = $DB->get_record('course', array('idnumber'=>$newgroup->idnumber))) {
@@ -144,7 +144,7 @@ if ($mform_post->is_cancelled()) {
$newgroup->courseid = $mycourse->id;
}
} else if (!empty($newgroup->coursename)) {
} else if (isset($newgroup->coursename) && strlen($newgroup->coursename)) {
//else use course short name to look up
//unset invalid coursename (if no id)
if (!$mycourse = $DB->get_record('course', array('shortname' => $newgroup->coursename))) {