L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-79280 mod_quiz: normalise cm instance in override form.

Browse Source
This commit is contained in:
Paul Holden
2023-09-22 10:32:06 +01:00
parent 88f4aafad9
commit 6015eca424
2 changed files with 30 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/quiz/classes/form/edit_override_form.php
+6
View File
@@ -70,6 +70,12 @@ class edit_override_form extends moodleform {
cm_info|stdClass $cm, stdClass $quiz, context_module $context,
bool $groupmode, ?stdClass $override) {
// Normalise our course module instance.
if (!($cm instanceof cm_info)) {
$course = get_course($quiz->course);
$cm = get_fast_modinfo($course)->get_cm($cm->id);
}
$this->cm = $cm;
$this->quiz = $quiz;
$this->context = $context;
mod/quiz/tests/behat/quiz_user_override.feature
+24
View File
@@ -59,6 +59,30 @@ Feature: Quiz user override
And I press "Continue"
And I should not see "Student One"
@javascript
Scenario: Add multiple user overrides, one after another
Given the following "activities" exist:
| activity | name | course | idnumber |
| quiz | Test quiz | C1 | quiz1 |
And I am on the "Test quiz" "mod_quiz > View" page logged in as "teacher"
And I change window size to "large"
And I navigate to "Overrides" in current page administration
And I press "Add user override"
And I set the following fields to these values:
| Override user | Student One |
| timeclose[enabled] | 1 |
| Close the quiz | ## 1 January 2020 08:00 ## |
And I press "Save and enter another override"
And I set the following fields to these values:
| Override user | Student Two |
| timeclose[enabled] | 1 |
| Close the quiz | ## 2 January 2020 08:00 ## |
When I press "Save"
Then the following should exist in the "generaltable" table:
| User | Overrides | -4- |
| Student One | Quiz closes | 1 January 2020, 8:00 |
| Student Two | Quiz closes | 2 January 2020, 8:00 |
@javascript
Scenario: Can add a user override when the quiz is not available to the student
Given the following "activities" exist: