Merge branch 'MDL-72658-master-welcometosite' of git://github.com/mudrd8mz/moodle

lang/en/moodle.php

@@ -2266,8 +2266,8 @@ $string['weeks'] = 'weeks';
 $string['weekhide'] = 'Hide this week from {$a}';
 $string['weeklyoutline'] = 'Weekly outline';
 $string['weekshow'] = 'Show this week to {$a}';
-$string['welcomeback'] = 'Welcome back, {$a}! 👋';
-$string['welcometosite'] = 'Welcome, {$a}! 👋';
+$string['welcomeback'] = 'Welcome back, {$a->firstname}! 👋';
+$string['welcometosite'] = 'Welcome, {$a->firstname}! 👋';
 $string['welcometocourse'] = 'Welcome to {$a}';
 $string['welcometocoursetext'] = 'Welcome to {$a->coursename}!
 

lib/classes/user.php

@@ -1189,7 +1189,17 @@ class core_user {
                 $messagekey = 'welcometosite';
                 set_user_preference('core_user_welcome', time());
             }
-            return new lang_string($messagekey, 'core', $USER->firstname);
+
+            $namefields = [
+                'fullname' => fullname($USER),
+                'alternativefullname' => fullname($USER, true),
+            ];
+
+            foreach (\core_user\fields::get_name_fields() as $namefield) {
+                $namefields[$namefield] = $USER->{$namefield};
+            }
+
+            return new lang_string($messagekey, 'core', $namefields);
         };
         return null;
     }