L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-32780: Use Moodle functions for building SQL in assignment upgrade tool

Browse Source 
Fixed functions:
tool_assignmentupgrade_load_all_upgradable_assignmentids() and
tool_assignmentupgrade_any_upgradable_assignments()
This commit is contained in:
Damyon Wiese
2012-05-07 10:54:24 +08:00
parent e16e2300c5
commit 5d81b754be
1 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/tool/assignmentupgrade/locallib.php
+6 -15
View File
@@ -131,16 +131,11 @@ function tool_assignmentupgrade_any_upgradable_assignments() {
$upgradabletypes[] = $shorttype;
}
}
$paramlist = '?';
foreach ($upgradabletypes as $index => $upgradabletype) {
if ($index > 0) {
$paramlist .= ', ?';
}
}
list($sql, $params) = $DB->get_in_or_equal($upgradabletypes);
$record = $DB->get_record_sql('SELECT COUNT(id) as count from {assignment} where assignmenttype in (' . $paramlist . ')', $upgradabletypes);
$count = $DB->count_records_sql('SELECT COUNT(id) from {assignment} where assignmenttype ' . $sql, $params);
return $record->count > 0;
return $count > 0;
}
/**
@@ -161,14 +156,10 @@ function tool_assignmentupgrade_load_all_upgradable_assignmentids() {
$upgradabletypes[] = $shorttype;
}
}
$paramlist = '?';
foreach ($upgradabletypes as $index => $upgradabletype) {
if ($index > 0) {
$paramlist .= ', ?';
}
}
$records = $DB->get_records_sql('SELECT id from {assignment} where assignmenttype in (' . $paramlist . ')', $upgradabletypes);
list($sql, $params) = $DB->get_in_or_equal($upgradabletypes);
$records = $DB->get_records_sql('SELECT id from {assignment} where assignmenttype ' . $sql, $params);
$ids = array();
foreach ($records as $record) {
$ids[] = $record->id;