L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-57795 mod_assign: fix for filters killing review pane when grading

Browse Source 
Fixes a bug in which the review pane was destroyed if the user selected
a combination of filters resulting in no matched users. Now, the pane
is just hidden in such cases, and displayed again if subsequent filter
changes return one or more users.
This commit is contained in:
Jake Dallimore
2017-02-20 08:51:35 +08:00
parent 9ec952f237
commit 5cb060b878
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/assign/amd/build/grading_panel.min.js
Vendored
+1 -1
View File
File diff suppressed because one or more lines are too long
mod/assign/amd/src/grading_panel.js
+2 -4
View File
@@ -298,12 +298,10 @@ define(['jquery', 'core/yui', 'core/notification', 'core/templates', 'core/fragm
}.bind(this))
.fail(notification.exception);
}.bind(this)).fail(notification.exception);
$('[data-region="review-panel"]').show();
} else {
this._region.hide();
var reviewPanel = $('[data-region="review-panel"]');
if (reviewPanel.length) {
this._niceReplaceNodeContents(reviewPanel, '', '');
}
$('[data-region="review-panel"]').hide();
$(document).trigger('finish-loading-user');
// Tell behat we are friends again.
window.M.util.js_complete('mod-assign-loading-user');